lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 27 Feb 2020 16:38:59 -0800 From: Guenter Roeck <linux@...ck-us.net> To: Doug Anderson <dianders@...omium.org> Cc: Minas Harutyunyan <hminas@...opsys.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Antti Seppälä <a.seppala@...il.com>, Boris ARZUR <boris@...bu.org>, linux-usb@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>, Felipe Balbi <balbi@...nel.org>, Stefan Wahren <stefan.wahren@...e.com>, Martin Schiller <ms@....tdt.de> Subject: Re: [RFT PATCH 4/4] usb: dwc2: Make "trimming xfer length" a debug message On Thu, Feb 27, 2020 at 02:07:14PM -0800, Doug Anderson wrote: > Hi, > > On Wed, Feb 26, 2020 at 1:04 PM Guenter Roeck <linux@...ck-us.net> wrote: > > > > With some USB network adapters, such as DM96xx, the following message > > is seen for each maximum size receive packet. > > > > dwc2 ff540000.usb: dwc2_update_urb_state(): trimming xfer length > > > > This happens because the packet size requested by the driver is 1522 > > bytes, wMaxPacketSize is 64, the dwc2 driver configures the chip to > > receive 24*64 = 1536 bytes, and the chip does indeed send more than > > 1522 bytes of data. Since the event does not indicate an error condition, > > the message is just noise. Demote it to debug level. > > > > Signed-off-by: Guenter Roeck <linux@...ck-us.net> > > --- > > drivers/usb/dwc2/hcd_intr.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Suggest a "Fixes" or "Cc: stable" tag. This one isn't as important as > the others, but presumably you'll start hitting it a lot more now > (whereas previously we'd just crash). > Good point. Added Fixes: 7359d482eb4d3 ("staging: HCD files for the DWC2 driver") > Reviewed-by: Douglas Anderson <dianders@...omium.org> Thanks again! Guenter
Powered by blists - more mailing lists