linux-kernel - Re: [PATCH] drm/dp_mst: Check crc4 value while building sideband message

Open Source and information security mailing list archives

Message-ID: <CA+M3ks6xifM2xwx6PR_xuLRYV2GEprtgcM7+_26Z3WbZMRrVeg@mail.gmail.com>
Date:   Fri, 28 Feb 2020 13:16:20 +0100
From:   Benjamin Gaignard <benjamin.gaignard@...aro.org>
To:     Lyude Paul <lyude@...hat.com>
Cc:     Benjamin Gaignard <benjamin.gaignard@...com>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        ML dri-devel <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH] drm/dp_mst: Check crc4 value while building sideband message

Le mar. 4 févr. 2020 à 20:00, Lyude Paul <lyude@...hat.com> a écrit :
>
> Reviewed-by: Lyude Paul <lyude@...hat.com>
>

Applied on drm-misc-next
Thanks,
Benjamin

> On Mon, 2020-02-03 at 13:16 +0100, Benjamin Gaignard wrote:
> > Check that computed crc value is matching the one encoded in the message.
> >
> > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@...com>
> > ---
> > CC: lyude@...hat.com
> > CC: airlied@...ux.ie
> > CC: jani.nikula@...ux.intel.com
> >  drivers/gpu/drm/drm_dp_mst_topology.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c
> > b/drivers/gpu/drm/drm_dp_mst_topology.c
> > index 822d2f177f90..eee899d6742b 100644
> > --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> > +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> > @@ -736,6 +736,10 @@ static bool drm_dp_sideband_msg_build(struct
> > drm_dp_sideband_msg_rx *msg,
> >       if (msg->curchunk_idx >= msg->curchunk_len) {
> >               /* do CRC */
> >               crc4 = drm_dp_msg_data_crc4(msg->chunk, msg->curchunk_len -
> > 1);
> > +             if (crc4 != msg->chunk[msg->curchunk_len - 1])
> > +                     print_hex_dump(KERN_DEBUG, "wrong crc",
> > +                                    DUMP_PREFIX_NONE, 16, 1,
> > +                                    msg->chunk,  msg->curchunk_len, false);
> >               /* copy chunk into bigger msg */
> >               memcpy(&msg->msg[msg->curlen], msg->chunk, msg->curchunk_len -
> > 1);
> >               msg->curlen += msg->curchunk_len - 1;
> --
> Cheers,
>         Lyude Paul
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives