linux-kernel - Re: [PATCH v3 5/6] MIPS: DTS: CI20: multiple DTS improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1582900568.3.2@crapouillou.net>
Date:   Fri, 28 Feb 2020 11:36:08 -0300
From:   Paul Cercueil <paul@...pouillou.net>
To:     "H. Nikolaus Schaller" <hns@...delico.com>
Cc:     Paul Boddie <paul@...die.org.uk>, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Paul Burton <paulburton@...nel.org>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Kees Cook <keescook@...omium.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        devicetree@...r.kernel.org, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org, letux-kernel@...nphoenux.org,
        kernel@...a-handheld.com
Subject: Re: [PATCH v3 5/6] MIPS: DTS: CI20: multiple DTS improvements

Hi Nikolaus,

Le dim., févr. 16, 2020 at 21:20, H. Nikolaus Schaller 
<hns@...delico.com> a écrit :
> a) add DT node for SW1 as Enter button
> 
> The SW1 button can be used as a simple one-button keyboard
> and is connected to PD17.
> 
> Note: SW1 has a second meaning to change the boot sequence
> when pressed while powering on.
> 
> b) give eth0_power a defined voltage.
> 
> This is a 3.3V power switch (DVNET3.3V ).
> 
> Signed-off-by: H. Nikolaus Schaller <hns@...delico.com>
> ---
>  arch/mips/boot/dts/ingenic/ci20.dts | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts 
> b/arch/mips/boot/dts/ingenic/ci20.dts
> index 1ab55be707af..4bacefa2cfce 100644
> --- a/arch/mips/boot/dts/ingenic/ci20.dts
> +++ b/arch/mips/boot/dts/ingenic/ci20.dts
> @@ -4,6 +4,7 @@
>  #include "jz4780.dtsi"
>  #include <dt-bindings/clock/ingenic,tcu.h>
>  #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>
> 
>  / {
>  	compatible = "img,ci20", "ingenic,jz4780";
> @@ -25,6 +26,17 @@
>  		       0x30000000 0x30000000>;
>  	};
> 
> +	gpio-keys {
> +		compatible = "gpio-keys";
> +
> +		sw1 {
> +			label = "ci20:sw1";
> +			linux,code = <KEY_ENTER>;

Why KEY_ENTER? It would make it impossible for applications to know 
that it's actually the switch that has been pressed an not the keyboard.

> +			gpios = <&gpd 17 GPIO_ACTIVE_HIGH>;
> +			wakeup-source;
> +		};
> +	};
> +
>  	leds {
>  		compatible = "gpio-leds";
> 
> @@ -56,6 +68,8 @@
>  	eth0_power: fixedregulator@0 {
>  		compatible = "regulator-fixed";
>  		regulator-name = "eth0_power";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
>  		gpio = <&gpb 25 GPIO_ACTIVE_LOW>;
>  		enable-active-high;
>  	};
> --
> 2.23.0
>