linux-kernel - Re: [PATCH v4 0/3] printk/console: Fix preferred console handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200228145820.6k4ddp457kf4e6c4@pathway.suse.cz>
Date:   Fri, 28 Feb 2020 15:58:20 +0100
From:   Petr Mladek <pmladek@...e.com>
To:     Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:     Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Peter Zijlstra <peterz@...radead.org>,
        John Ogness <john.ogness@...utronix.de>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 0/3] printk/console: Fix preferred console handling

On Fri 2020-02-28 09:14:47, Benjamin Herrenschmidt wrote:
> On Tue, 2020-02-18 at 10:52 +0100, Petr Mladek wrote:
> > On Mon 2020-02-17 22:03:08, Sergey Senozhatsky wrote:
> > > On (20/02/13 10:51), Petr Mladek wrote:
> > > > Hi,
> > > > 
> > > > I send this on behalf of Benjamin who is traveling at the moment.
> > > > It is an interesting approach to long terms problems with
> > > > matching
> > > > the console preferred on the command line.
> > > > 
> > > > Changes against v3:
> > > > 
> > > > 	+ better check when accepting pre-enabled consoles
> > > > 	+ correct reasoning in the 3rd patch
> > > > 	+ update a comment of CON_CONSDEV definition
> > > > 	+ fixed checkpatch warnings
> > > 
> > > Looks good to me,
> > > 
> > > Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> > 
> > The patchset is commited in printk.git, branch
> > for-5.7-preferred-console.
> > 
> Do you plan to send any of this to -stable ?

Good question. I would prefer to wait until 5.7 gets release or even
longer. Changes in console registration order are prone to
regressions. People then complain that they do not longer see console
after reboot.

linux-next and rc phase has only pretty limited number of users.
Released kernels hit much bigger user base, for example, via
OpenSUSE Tumbleweed.

Best Regards,
Petr