lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 29 Feb 2020 00:39:34 +0000 From: Colin Ian King <colin.king@...onical.com> To: Theodore Ts'o <tytso@....edu>, Andreas Dilger <adilger.kernel@...ger.ca>, Ext4 Developers List <linux-ext4@...r.kernel.org> Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: re: ext4: convert file system to meta_bg if needed during resizing Hi, static analysis with Coverity has found an issue in function ext4_convert_meta_bg() with the following commit commit 1c6bd7173d66b3dfdefcedb38cabc1fb03997509 Author: Theodore Ts'o <tytso@....edu> Date: Thu Sep 13 10:19:24 2012 -0400 ext4: convert file system to meta_bg if needed during resizing The analysis is as follows: 1898 1899 errout: 1900 ret = ext4_journal_stop(handle); 1901 if (!err) Unused value (UNUSED_VALUE)assigned_value: Assigning value from ret to err here, but that stored value is not used. 1902 err = ret; 1903 return ret; I'm not entirely sure why !err is being checked and then err is being re-assigned and then is not used. Colin
Powered by blists - more mailing lists