[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1708ec617b1.116fbb3c620013.4511572987202965377@flygoat.com>
Date: Sat, 29 Feb 2020 10:28:31 +0800
From: Jiaxun Yang <jiaxun.yang@...goat.com>
To: "Rob Herring" <robh@...nel.org>
Cc: "linux-mips" <linux-mips@...r.kernel.org>,
"Thomas Gleixner" <tglx@...utronix.de>,
"Jason Cooper" <jason@...edaemon.net>,
"Marc Zyngier" <maz@...nel.org>,
"Mark Rutland" <mark.rutland@....com>,
"Ralf Baechle" <ralf@...ux-mips.org>,
"Paul Burton" <paulburton@...nel.org>,
"Huacai Chen" <chenhc@...ote.com>,
"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
"Allison Randal" <allison@...utok.net>,
"linux-kernel" <linux-kernel@...r.kernel.org>,
"devicetree" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v4 07/10] dt-bindings: mips: Add loongson boards
---- 在 星期四, 2020-02-27 00:52:11 Rob Herring <robh@...nel.org> 撰写 ----
> On Fri, Feb 21, 2020 at 01:09:22PM +0800, Jiaxun Yang wrote:
> > Prepare for later dts.
> >
> > Signed-off-by: Jiaxun Yang <jiaxun.yang@...goat.com>
> > ---
> > .../bindings/mips/loongson/devices.yaml | 29 +++++++++++++++++++
> > 1 file changed, 29 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/mips/loongson/devices.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/mips/loongson/devices.yaml b/Documentation/devicetree/bindings/mips/loongson/devices.yaml
> > new file mode 100644
> > index 000000000000..32bec784da87
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mips/loongson/devices.yaml
> > @@ -0,0 +1,29 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/mips/loongson/devices.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Loongson based Platforms Device Tree Bindings
> > +
> > +maintainers:
> > + - Jiaxun Yang <jiaxun.yang@...goat.com>
> > +description: |
> > + Devices with a Loongson CPU shall have the following properties.
>
> Perhaps some details about the platform.
>
> > + Note that generic device is used for built-in dtbs and will be
> > + patched during boot on firmware without OF support.
>
> That's a kernel detail that doesn't belong here. (BTW, built-in dtb
> support is intended as a transition step for bootloaders without dtb
> knowledge. It's not the recommended way and shouldn't be used on new
> platforms).
Yes, it's used to deal with legacy platforms.
Will drop this line in next version.
Thanks.
>
> > +
> > +properties:
> > + $nodename:
> > + const: '/'
> > + compatible:
> > + oneOf:
> > +
> > + - description: Generic Loongson3 4Core + RS780E
> > + items:
> > + - const: loongson,loongson3-4core-rs780e
> > +
> > + - description: Generic Loongson3 8Core + RS780E
> > + items:
> > + - const: loongson,loongson3-8core-rs780e
> > +...
> > --
> > 2.25.0
> >
> >
>
Powered by blists - more mailing lists