linux-kernel - Re: [PATCH v1 1/4] dt-binding: watchdog: add restart priority documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ecf9a6b-8fca-1e7a-10d0-ee518e6ecf64@roeck-us.net>
Date:   Sun, 1 Mar 2020 02:05:58 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Tomer Maimon <tmaimon77@...il.com>, wim@...ux-watchdog.org,
        robh+dt@...nel.org, mark.rutland@....com, joel@....id.au,
        avifishman70@...il.com, tali.perry1@...il.com, yuenn@...gle.com,
        benjaminfair@...gle.com
Cc:     linux-watchdog@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, openbmc@...ts.ozlabs.org
Subject: Re: [PATCH v1 1/4] dt-binding: watchdog: add restart priority
 documentation

On 3/1/20 1:40 AM, Tomer Maimon wrote:
> Add device tree restart priority documentation.
> 

I think this warrants an explanation _why_ this is needed.
What is the use case ? Not just theory, please.

Guenter

> Signed-off-by: Tomer Maimon <tmaimon77@...il.com>
> ---
>  Documentation/devicetree/bindings/watchdog/nuvoton,npcm-wdt.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/nuvoton,npcm-wdt.txt b/Documentation/devicetree/bindings/watchdog/nuvoton,npcm-wdt.txt
> index 6d593003c933..0a0f86a25eb0 100644
> --- a/Documentation/devicetree/bindings/watchdog/nuvoton,npcm-wdt.txt
> +++ b/Documentation/devicetree/bindings/watchdog/nuvoton,npcm-wdt.txt
> @@ -17,6 +17,7 @@ Required clocking property, have to be one of:
>  
>  Optional properties:
>  - timeout-sec : Contains the watchdog timeout in seconds
> +- nuvoton,restart-priority : Contains the card restart priority.
>  
>  Example:
>  
> @@ -25,4 +26,5 @@ timer@...0801c {
>      interrupts = <GIC_SPI 47 IRQ_TYPE_LEVEL_HIGH>;
>      reg = <0xf000801c 0x4>;
>      clocks = <&clk NPCM7XX_CLK_TIMER>;
> +	nuvoton,restart-priority = <155>;
>  };
>