linux-kernel - Re: [PATCH] iio: adc: ad9292: Use new structure for SPI transfer delays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200301143647.7e611d6b@archlinux>
Date:   Sun, 1 Mar 2020 14:36:47 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Sergiu Cuciurean <sergiu.cuciurean@...log.com>
Cc:     <linux-kernel@...r.kernel.org>, <linux-iio@...r.kernel.org>,
        <pmeerw@...erw.net>, <Michael.Hennerich@...log.com>,
        <marcelo.schmitt1@...il.com>
Subject: Re: [PATCH] iio: adc: ad9292: Use new structure for SPI transfer
 delays

On Thu, 27 Feb 2020 14:18:14 +0200
Sergiu Cuciurean <sergiu.cuciurean@...log.com> wrote:

> In a recent change to the SPI subsystem [1], a new `delay` struct was added
> to replace the `delay_usecs`. This change replaces the current
> `delay_usecs` with `delay` for this driver.
> 
> The `spi_transfer_delay_exec()` function [in the SPI framework] makes sure
> that both `delay_usecs` & `delay` are used (in this order to preserve
> backwards compatibility).
> 
> [1] commit bebcfd272df6 ("spi: introduce `delay` field for
> `spi_transfer` + spi_transfer_delay_exec()")
> 
> Signed-off-by: Sergiu Cuciurean <sergiu.cuciurean@...log.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/ad7292.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/ad7292.c b/drivers/iio/adc/ad7292.c
> index a6798f7dfdb8..6595fd196288 100644
> --- a/drivers/iio/adc/ad7292.c
> +++ b/drivers/iio/adc/ad7292.c
> @@ -122,7 +122,10 @@ static int ad7292_single_conversion(struct ad7292_state *st,
>  		{
>  			.tx_buf = &st->d8,
>  			.len = 4,
> -			.delay_usecs = 6,
> +			.delay = {
> +				.value = 6,
> +				.unit = SPI_DELAY_UNIT_USECS
> +			},
>  		}, {
>  			.rx_buf = &st->d16,
>  			.len = 2,