linux-kernel - Re: [PATCH] iio: adc: max1118: Use new structure for SPI transfer delays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200301154920.208b7b38@archlinux>
Date:   Sun, 1 Mar 2020 15:49:20 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Sergiu Cuciurean <sergiu.cuciurean@...log.com>
Cc:     <linux-kernel@...r.kernel.org>, <linux-iio@...r.kernel.org>,
        <pmeerw@...erw.net>, <lars@...afoo.de>, <knaack.h@....de>,
        <tglx@...utronix.de>, <alexios.zavras@...el.com>,
        <allison@...utok.net>, <kstewart@...uxfoundation.org>
Subject: Re: [PATCH] iio: adc: max1118: Use new structure for SPI transfer
 delays

On Thu, 27 Feb 2020 14:25:15 +0200
Sergiu Cuciurean <sergiu.cuciurean@...log.com> wrote:

> In a recent change to the SPI subsystem [1], a new `delay` struct was added
> to replace the `delay_usecs`. This change replaces the current
> `delay_usecs` with `delay` for this driver.
> 
> The `spi_transfer_delay_exec()` function [in the SPI framework] makes sure
> that both `delay_usecs` & `delay` are used (in this order to preserve
> backwards compatibility).
> 
> [1] commit bebcfd272df6 ("spi: introduce `delay` field for
> `spi_transfer` + spi_transfer_delay_exec()")
> 
> Signed-off-by: Sergiu Cuciurean <sergiu.cuciurean@...log.com>
Applied to the togreg branch of iio.git and pushed out as testing for the
autobuilders to play with it.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/max1118.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/max1118.c b/drivers/iio/adc/max1118.c
> index 3b6f3b9a6c5b..0c5d7aaf6826 100644
> --- a/drivers/iio/adc/max1118.c
> +++ b/drivers/iio/adc/max1118.c
> @@ -71,7 +71,10 @@ static int max1118_read(struct spi_device *spi, int channel)
>  		 */
>  		{
>  			.len = 0,
> -			.delay_usecs = 1,	/* > CNVST Low Time 100 ns */
> +			.delay = {	/* > CNVST Low Time 100 ns */
> +				.value = 1,
> +				.unit = SPI_DELAY_UNIT_USECS
> +			},
>  			.cs_change = 1,
>  		},
>  		/*
> @@ -81,7 +84,10 @@ static int max1118_read(struct spi_device *spi, int channel)
>  		 */
>  		{
>  			.len = 0,
> -			.delay_usecs = 8,
> +			.delay = {
> +				.value = 8,
> +				.unit = SPI_DELAY_UNIT_USECS
> +			},
>  		},
>  		{
>  			.rx_buf = &adc->data,