linux-kernel - Re: [PATCH] iio: imu: adis_buffer: Use new structure for SPI transfer delays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200301155300.455551fa@archlinux>
Date:   Sun, 1 Mar 2020 15:53:00 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Sergiu Cuciurean <sergiu.cuciurean@...log.com>
Cc:     <linux-kernel@...r.kernel.org>, <linux-iio@...r.kernel.org>,
        <lars@...afoo.de>, <Michael.Hennerich@...log.com>,
        <knaack.h@....de>, <pmeerw@...erw.net>
Subject: Re: [PATCH] iio: imu: adis_buffer: Use new structure for SPI
 transfer delays

On Thu, 27 Feb 2020 14:38:59 +0200
Sergiu Cuciurean <sergiu.cuciurean@...log.com> wrote:

> In a recent change to the SPI subsystem [1], a new `delay` struct was added
> to replace the `delay_usecs`. This change replaces the current
> `delay_usecs` with `delay` for this driver.
> 
> The `spi_transfer_delay_exec()` function [in the SPI framework] makes sure
> that both `delay_usecs` & `delay` are used (in this order to preserve
> backwards compatibility).
> 
> [1] commit bebcfd272df6 ("spi: introduce `delay` field for
> `spi_transfer` + spi_transfer_delay_exec()")
> 
> Signed-off-by: Sergiu Cuciurean <sergiu.cuciurean@...log.com>
Applied.

Thanks,

Jonathan

> ---
>  drivers/iio/imu/adis_buffer.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/imu/adis_buffer.c b/drivers/iio/imu/adis_buffer.c
> index 3f4dd5c00b03..04e5e2a0fd6b 100644
> --- a/drivers/iio/imu/adis_buffer.c
> +++ b/drivers/iio/imu/adis_buffer.c
> @@ -97,7 +97,8 @@ int adis_update_scan_mode(struct iio_dev *indio_dev,
>  		if (j != scan_count)
>  			adis->xfer[j].cs_change = 1;
>  		adis->xfer[j].len = 2;
> -		adis->xfer[j].delay_usecs = adis->data->read_delay;
> +		adis->xfer[j].delay.value = adis->data->read_delay;
> +		adis->xfer[j].delay.unit = SPI_DELAY_UNIT_USECS;
>  		if (j < scan_count)
>  			adis->xfer[j].tx_buf = &tx[j];
>  		if (j >= 1)