linux-kernel - Re: [PATCH v3 1/3] virtio-net: Introduce extended RSC feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200301145828-mutt-send-email-mst@kernel.org>
Date:   Sun, 1 Mar 2020 15:06:00 -0500
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     Yuri Benditovich <yuri.benditovich@...nix.com>
Cc:     jasowang@...hat.com, virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, yan@...nix.com,
        virtio-dev@...ts.oasis-open.org
Subject: Re: [PATCH v3 1/3] virtio-net: Introduce extended RSC feature

On Sun, Mar 01, 2020 at 04:33:00PM +0200, Yuri Benditovich wrote:
> VIRTIO_NET_F_RSC_EXT feature bit indicates that the device
> is able to provide extended RSC information. When the feature
> is negotiatede and 'gso_type' field in received packet is not
> GSO_NONE, the device reports number of coalesced packets in
> 'csum_start' field and number of duplicated acks in 'csum_offset'
> field and sets VIRTIO_NET_HDR_F_RSC_INFO in 'flags' field.
> 
> Signed-off-by: Yuri Benditovich <yuri.benditovich@...nix.com>
> ---
>  include/uapi/linux/virtio_net.h | 22 ++++++++++++++++++++--
>  1 file changed, 20 insertions(+), 2 deletions(-)
> 
> diff --git a/include/uapi/linux/virtio_net.h b/include/uapi/linux/virtio_net.h
> index a3715a3224c1..19e76b3e3a64 100644
> --- a/include/uapi/linux/virtio_net.h
> +++ b/include/uapi/linux/virtio_net.h
> @@ -57,6 +57,7 @@
>  					 * Steering */
>  #define VIRTIO_NET_F_CTRL_MAC_ADDR 23	/* Set MAC address */
>  
> +#define VIRTIO_NET_F_RSC_EXT	  61	/* extended coalescing info */
>  #define VIRTIO_NET_F_STANDBY	  62	/* Act as standby for another device
>  					 * with the same MAC.
>  					 */
> @@ -104,6 +105,7 @@ struct virtio_net_config {
>  struct virtio_net_hdr_v1 {
>  #define VIRTIO_NET_HDR_F_NEEDS_CSUM	1	/* Use csum_start, csum_offset */
>  #define VIRTIO_NET_HDR_F_DATA_VALID	2	/* Csum is valid */
> +#define VIRTIO_NET_HDR_F_RSC_INFO	4	/* rsc info in csum_ fields */
>  	__u8 flags;
>  #define VIRTIO_NET_HDR_GSO_NONE		0	/* Not a GSO frame */
>  #define VIRTIO_NET_HDR_GSO_TCPV4	1	/* GSO frame, IPv4 TCP (TSO) */
> @@ -113,8 +115,24 @@ struct virtio_net_hdr_v1 {
>  	__u8 gso_type;
>  	__virtio16 hdr_len;	/* Ethernet + IP + tcp/udp hdrs */
>  	__virtio16 gso_size;	/* Bytes to append to hdr_len per frame */
> -	__virtio16 csum_start;	/* Position to start checksumming from */
> -	__virtio16 csum_offset;	/* Offset after that to place checksum */
> +	union {
> +		struct {
> +			__virtio16 csum_start;
> +			__virtio16 csum_offset;
> +		};


Pls add comments for this one as well.

> +		struct {
> +			/* Position to start checksumming from */
> +			__virtio16 start;
> +			/* Offset after that to place checksum */
> +			__virtio16 offset;
> +		} csum;

Can we add a comment for csum field pls? E.g.
	/* Checksum calculation */

> +		struct {
> +			/* num of coalesced packets */


num -> Number? Don't abbreviate and upper case for consistency.

> +			__le16 packets;

packets -> coalesced_packets? Or is coalesced segments in fact better?

> +			/* num of duplicated acks */

num -> Number? Don't abbreviate and upper case for consistency.


> +			__le16 dup_acks;
> +		} rsc;

/* Receive Segment Coalescing report */

> +	};
>  	__virtio16 num_buffers;	/* Number of merged rx buffers */
>  };
>  
> -- 
> 2.17.1