linux-kernel - Re: [PATCH] mm/vmscan.c: Clean code by removing unnecessary assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200301001148.GM29971@bombadil.infradead.org>
Date:   Sat, 29 Feb 2020 16:11:48 -0800
From:   Matthew Wilcox <willy@...radead.org>
To:     mateusznosek0@...il.com
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        akpm@...ux-foundation.org
Subject: Re: [PATCH] mm/vmscan.c: Clean code by removing unnecessary
 assignment

On Sat, Feb 29, 2020 at 10:40:22PM +0100, mateusznosek0@...il.com wrote:
> From: Mateusz Nosek <mateusznosek0@...il.com>
> 
> Previously 0 was assigned to variable 'lruvec_size',
> but the variable was never read later.
> So the assignment can be removed.
> 
> Signed-off-by: Mateusz Nosek <mateusznosek0@...il.com>

It _was_ used, until commit f87bccde6a7dd1bdb219a4045e8ac111590c9314
which removed lru_pages.  So this is just a left-over, and I agree it's
now superfluous.

Reviewed-by: Matthew Wilcox (Oracle) <willy@...radead.org>