linux-kernel - Re: [PATCH RESEND] virtio: virtio_pci_legacy: Remove default y from Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200301023025-mutt-send-email-mst@kernel.org>
Date:   Sun, 1 Mar 2020 02:32:30 -0500
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     Ram Muthiah <rammuthiah@...gle.com>
Cc:     Jason Wang <jasowang@...hat.com>,
        virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, kernel-team@...roid.com
Subject: Re: [PATCH RESEND] virtio: virtio_pci_legacy: Remove default y from
 Kconfig

On Fri, Feb 28, 2020 at 03:27:36PM -0800, Ram Muthiah wrote:
> The legacy pci driver should no longer be default enabled. QEMU has
> implemented support for Virtio 1 for virtio-pci since June 2015
> on SHA dfb8e184db75.
> 
> Signed-off-by: Ram Muthiah <rammuthiah@...gle.com>

I see little reason to do this: y is safer and will boot on more
hypervisors, so people that aren't sure should enable it.

> ---
>  drivers/virtio/Kconfig | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
> index 078615cf2afc..eacd0b90d32b 100644
> --- a/drivers/virtio/Kconfig
> +++ b/drivers/virtio/Kconfig
> @@ -26,7 +26,6 @@ config VIRTIO_PCI
>  
>  config VIRTIO_PCI_LEGACY
>  	bool "Support for legacy virtio draft 0.9.X and older devices"
> -	default y
>  	depends on VIRTIO_PCI
>  	---help---
>            Virtio PCI Card 0.9.X Draft (circa 2014) and older device support.
> @@ -36,11 +35,6 @@ config VIRTIO_PCI_LEGACY
>  	  If disabled, you get a slightly smaller, non-transitional driver,
>  	  with no legacy compatibility.
>  
> -          So look out into your driveway.  Do you have a flying car?  If
> -          so, you can happily disable this option and virtio will not
> -          break.  Otherwise, leave it set.  Unless you're testing what
> -          life will be like in The Future.
> -
>  	  If unsure, say Y.
>  
>  config VIRTIO_PMEM
> -- 
> 2.25.0.265.gbab2e86ba0-goog