linux-kernel - Re: [PATCH] arm64: dts: rockchip: Add txpbl node for RK3399/RK3328

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6132615.msM8OCcsVu@phil>
Date:   Sun, 01 Mar 2020 01:25:16 +0100
From:   Heiko Stuebner <heiko@...ech.de>
To:     Carlos de Paula <me@...losedp.com>
Cc:     papadakospan@...il.com, jose.abreu@...opsys.com,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Robin Murphy <robin.murphy@....com>,
        Jonas Karlman <jonas@...boo.se>,
        Peter Geis <pgwipeout@...il.com>,
        Katsuhiro Suzuki <katsuhiro@...suster.net>,
        Johan Jonker <jbx6244@...il.com>,
        Philipp Tomsich <philipp.tomsich@...obroma-systems.com>,
        Christoph Muellner <christoph.muellner@...obroma-systems.com>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: Add txpbl node for RK3399/RK3328

Am Dienstag, 18. Februar 2020, 23:10:37 CET schrieb Carlos de Paula:
> Some rockchip SoCs like the RK3399 and RK3328 exhibit an issue
> where tx checksumming does not work with packets larger than 1498.
> 
> The default Programmable Buffer Length for TX in these GMAC's is
> not suitable for MTUs higher than 1498. The workaround is to disable
> TX offloading with 'ethtool -K eth0 tx off rx off' causing performance
> impacts as it disables hardware checksumming.
> 
> This patch sets snps,txpbl to 0x4 which is a safe number tested ok for
> the most popular MTU value of 1500.
> 
> For reference, see https://lkml.org/lkml/2019/4/1/1382.
> 
> Signed-off-by: Carlos de Paula <me@...losedp.com>

applied for 5.7

Thanks
Heiko