linux-kernel - Re: [PATCH 1/2] pty: define and set show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 2 Mar 2020 14:37:55 +0100
From:   Tobias Klauser <tklauser@...tanz.ch>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Jiri Slaby <jslaby@...e.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] pty: define and set show_fdinfo only if procfs is
 enabled

On 2020-03-02 at 11:51:53 +0100, Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:
> On Mon, Mar 02, 2020 at 11:49:53AM +0100, Tobias Klauser wrote:
> > Follow the pattern used with other *_show_fdinfo functions and only
> > define and use pty_show_fdinfo if CONFIG_PROC_FS is set.
> 
> if proc_fs is not set, it will not be used anyway, right?

Right, it should never get called.

> I'd rather keep #ifdef out of the .c files than add this.  How much
> memory does it save, and are you using a system without procfs that
> needs this savings?

The savings are marginal, so no I don't strictly need this. I just
figured all other *_show_fdinfo functions in the tree are #ifdef'ed in
the same way and it would be nice to be consistent.

Thanks