linux-kernel - Re: [PATCH] mm/mm_init.c: Clean code. Use BUILD_BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 2 Mar 2020 13:51:37 +0000
From:   Wei Yang <richard.weiyang@...il.com>
To:     mateusznosek0@...il.com
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        akpm@...ux-foundation.org
Subject: Re: [PATCH] mm/mm_init.c: Clean code. Use BUILD_BUG_ON when
 comparing compile time constant

On Fri, Feb 28, 2020 at 11:46:17PM +0100, mateusznosek0@...il.com wrote:
>From: Mateusz Nosek <mateusznosek0@...il.com>
>
>MAX_ZONELISTS is compile time constant,
>so it should be compared using BUILD_BUG_ON not BUG_ON.
>
>Signed-off-by: Mateusz Nosek <mateusznosek0@...il.com>

Sounds you are right.

Reviewed-by: Wei Yang <richard.weiyang@...il.com>

>---
> mm/mm_init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/mm/mm_init.c b/mm/mm_init.c
>index 5c918388de99..7da6991d9435 100644
>--- a/mm/mm_init.c
>+++ b/mm/mm_init.c
>@@ -37,7 +37,7 @@ void __init mminit_verify_zonelist(void)
> 		struct zonelist *zonelist;
> 		int i, listid, zoneid;
> 
>-		BUG_ON(MAX_ZONELISTS > 2);
>+		BUILD_BUG_ON(MAX_ZONELISTS > 2);
> 		for (i = 0; i < MAX_ZONELISTS * MAX_NR_ZONES; i++) {
> 
> 			/* Identify the zone and nodelist */
>-- 
>2.17.1

-- 
Wei Yang
Help you, Help me