[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200302140309.GM4380@dhcp22.suse.cz>
Date: Mon, 2 Mar 2020 15:03:09 +0100
From: Michal Hocko <mhocko@...nel.org>
To: David Hildenbrand <david@...hat.com>
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org,
virtio-dev@...ts.oasis-open.org,
virtualization@...ts.linux-foundation.org, kvm@...r.kernel.org,
Andrew Morton <akpm@...ux-foundation.org>,
"Michael S . Tsirkin" <mst@...hat.com>,
"Rafael J. Wysocki" <rafael@...nel.org>,
Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org
Subject: Re: [PATCH v1 01/11] ACPI: NUMA: export pxm_to_node
On Mon 02-03-20 14:49:31, David Hildenbrand wrote:
> Will be needed by virtio-mem to identify the node from a pxm.
No objection to export the symbol. But it is almost always better to add
the export in the patch that actually uses it. The intention is much
more clear that way.
> Acked-by: "Rafael J. Wysocki" <rafael@...nel.org>
> Cc: Len Brown <lenb@...nel.org>
> Cc: linux-acpi@...r.kernel.org
> Signed-off-by: David Hildenbrand <david@...hat.com>
Acked-by: Michal Hocko <mhocko@...e.com> # for the export
> ---
> drivers/acpi/numa/srat.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c
> index 47b4969d9b93..5be5a977da1b 100644
> --- a/drivers/acpi/numa/srat.c
> +++ b/drivers/acpi/numa/srat.c
> @@ -35,6 +35,7 @@ int pxm_to_node(int pxm)
> return NUMA_NO_NODE;
> return pxm_to_node_map[pxm];
> }
> +EXPORT_SYMBOL(pxm_to_node);
>
> int node_to_pxm(int node)
> {
> --
> 2.24.1
>
--
Michal Hocko
SUSE Labs
Powered by blists - more mailing lists