linux-kernel - Re: [PATCH v1 01/11] ACPI: NUMA: export pxm_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <baff6701-fc75-d205-2e78-904166f63030@redhat.com>
Date:   Mon, 2 Mar 2020 15:09:10 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Michal Hocko <mhocko@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        virtio-dev@...ts.oasis-open.org,
        virtualization@...ts.linux-foundation.org, kvm@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        "Michael S . Tsirkin" <mst@...hat.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org
Subject: Re: [PATCH v1 01/11] ACPI: NUMA: export pxm_to_node

On 02.03.20 15:03, Michal Hocko wrote:
> On Mon 02-03-20 14:49:31, David Hildenbrand wrote:
>> Will be needed by virtio-mem to identify the node from a pxm.
> 
> No objection to export the symbol. But it is almost always better to add
> the export in the patch that actually uses it. The intention is much
> more clear that way.

Yeah, but I guess this way people might take more likely a look as if
this would be squashed into a
 5 files changed, 1786 insertions(+)

patch. At least that's what my experience tells me :)

If there are hard feelings, I can squash (but I am afraid it will be
even harder to get ACKs/RBs for core-mm changes that way ...)

Thanks for having a look!

-- 
Thanks,

David / dhildenb