linux-kernel - Re: [PATCH RESEND] dt-bindings: power: Fix dt_binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 2 Mar 2020 23:58:08 +0800
From:   Jianxin Pan <jianxin.pan@...ogic.com>
To:     Kevin Hilman <khilman@...libre.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        <linux-amlogic@...ts.infradead.org>
CC:     Rob Herring <robh+dt@...nel.org>, <devicetree@...r.kernel.org>,
        Neil Armstrong <narmstrong@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        <linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH RESEND] dt-bindings: power: Fix dt_binding_check error


Hi Kevin,


On 2020/3/1 0:28, Kevin Hilman wrote:
> Hi Jianxin,
> 
> Jianxin Pan <jianxin.pan@...ogic.com> writes:
> 
>> Missing ';' in the end of secure-monitor example node.
>>
>> Fixes: f50b4108ede1 ("dt-bindings: power: add Amlogic secure power domains bindings")
> 
> Thanks for the fix, but where did this commit ID come from?  I think
> this is the right upstream commit:
> 
> Fixes: 165b5fb294e8 ("dt-bindings: power: add Amlogic secure power domains bindings")
> 
> Also, when you resend, can you cc soc@...nel.org.  The soc maintainers
> are who queue my amlogic tree.  I will ack and they can submit to Linus
> for v5.7 so Stephen doesn't have to carry his local linux-next fix
> anymore.
> 
> Thanks,
The commit id is not correct, it from my local branch.
I corrected it and added soc maintainers to the cc list.
Thanks for your time. 
> 
> Kevin
> 
>> Reported-by: Rob Herring <robh+dt@...nel.org>
>> Signed-off-by: Jianxin Pan <jianxin.pan@...ogic.com>
>> Reviewed-by: Neil Armstrong <narmstrong@...libre.com>
>> Acked-by: Rob Herring <robh@...nel.org>
>> ---
>>  Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
>> index af32209..bc4e037 100644
>> --- a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
>> +++ b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
>> @@ -36,5 +36,5 @@ examples:
>>              compatible = "amlogic,meson-a1-pwrc";
>>              #power-domain-cells = <1>;
>>          };
>> -    }
>> +    };
>>  
>> -- 
>> 2.7.4
> 
> .
>