linux-kernel - Re: [PATCH] KVM: SVM: Fix svm the vmexit error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <30830ba4-d8d3-df58-f039-57e750ae90a7@redhat.com>
Date:   Mon, 2 Mar 2020 17:05:02 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Vitaly Kuznetsov <vkuznets@...hat.com>,
        Haiwei Li <lihaiwei.kernel@...il.com>
Cc:     hpa@...or.com, bp@...en8.de, "mingo@...hat.com" <mingo@...hat.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "joro@...tes.org" <joro@...tes.org>, jmattson@...gle.com,
        wanpengli@...cent.com,
        Sean Christopherson <sean.j.christopherson@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        kvm@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH] KVM: SVM: Fix svm the vmexit error_code of WRMSR

On 02/03/20 13:54, Vitaly Kuznetsov wrote:
>>          enum exit_fastpath_completion *exit_fastpath)
>>   {
>>          if (!is_guest_mode(vcpu) &&
>> -               to_svm(vcpu)->vmcb->control.exit_code ==
>> EXIT_REASON_MSR_WRITE)
> There is an extra newline here (in case it's not just me).

Yes, the whole patch has broken newlines.  I fixed it up and applied.

>> +               (to_svm(vcpu)->vmcb->control.exit_code == SVM_EXIT_MSR) &&
>> +               (to_svm(vcpu)->vmcb->control.exit_info_1 & 1))
>
> Could we add defines for '1' and '0', like
> SVM_EXITINFO_MSR_WRITE/SVM_EXITINFO_MSR_READ maybe?

We can eliminate "& 1" completely since that's what msr_interception does.

Paolo