[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 3 Mar 2020 07:36:22 -0800
From: Tony Lindgren <tony@...mide.com>
To: Tomi Valkeinen <tomi.valkeinen@...com>
Cc: linux-omap@...r.kernel.org, "Andrew F . Davis" <afd@...com>,
Dave Gerlach <d-gerlach@...com>,
Faiz Abbas <faiz_abbas@...com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Keerthy <j-keerthy@...com>, Nishanth Menon <nm@...com>,
Peter Ujfalusi <peter.ujfalusi@...com>,
Roger Quadros <rogerq@...com>, Suman Anna <s-anna@...com>,
Tero Kristo <t-kristo@...com>, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
dri-devel@...ts.freedesktop.org, Jyri Sarha <jsarha@...com>,
Laurent Pinchart <laurent.pinchart@...asonboard.com>
Subject: Re: [PATCH 1/3] drm/omap: Prepare DSS for probing without legacy
platform data
* Tomi Valkeinen <tomi.valkeinen@...com> [200303 09:19]:
> On 24/02/2020 21:12, Tony Lindgren wrote:
> > In order to probe display subsystem (DSS) components with ti-sysc
> > interconnect target module without legacy platform data and using
> > devicetree, we need to update dss probing a bit.
> >
> > In the device tree, we will be defining the data also for the interconnect
> > target modules as DSS really is a private interconnect. There is some
> > information about that in 4460 TRM in "Figure 10-3. DSS Integration" for
> > example where it mentions "32-bit interconnect (SLX)".
> >
> > The changes we need to make are:
> >
> > 1. Parse also device tree subnodes for the compatible property fixup
> >
> > 2. Update the component code to consider device tree subnodes
> >
> > Cc: dri-devel@...ts.freedesktop.org
> > Cc: Jyri Sarha <jsarha@...com>
> > Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> > Cc: Tomi Valkeinen <tomi.valkeinen@...com>
> > Signed-off-by: Tony Lindgren <tony@...mide.com>
> > ---
> >
> > This is needed for dropping DSS platform data that I'll be posting
> > seprately. If this looks OK, can you guys please test and ack?
> >
> > ---
> > drivers/gpu/drm/omapdrm/dss/dss.c | 25 ++++++++++++++++---
> > .../gpu/drm/omapdrm/dss/omapdss-boot-init.c | 25 +++++++++++++------
> > 2 files changed, 39 insertions(+), 11 deletions(-)
>
> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@...com>
>
> This doesn't conflict with drm-next (with Laurent's recent patches), so it
> should be fine for you to have this in your branch.
OK thank you. I've pushed out omap-for-v5.7/dss-probe which has just
this commit against v5.6-rc1 [0][1]. Let's consider commit cef766300353
("drm/omap: Prepare DSS for probing without legacy platform data")
immutable so we can both merge it in as needed.
I have not added any tag yet as it seems that we could add also
apply Sebastian's few preparatory dts changes to this branch when
ready.
> And not a biggie, but I wonder if the changes to these two files should be
> in separate patches, due to omapdss-boot-init going away. Well, probably
> doesn't matter.
Hmm yeah good reason to put every change into a seprate patch
for future. I really did not expect this to conflict with anything
after years of no changes :)
Regards,
Tony
[0] git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git omap-for-v5.7/dss-probe
[1] https://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git/commit/?h=omap-for-v5.7/dss-probe&id=cef766300353613aa273791f70b3125d1f0420ae
Powered by blists - more mailing lists