linux-kernel - Re: [PATCH] ASoC: amd: AMD RV RT5682 should depends on CROS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 3 Mar 2020 08:54:34 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        linux-kernel@...r.kernel.org
Cc:     Collabora Kernel ML <kernel@...labora.com>,
        Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
        Akshu Agrawal <akshu.agrawal@....com>,
        Mark Brown <broonie@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Takashi Iwai <tiwai@...e.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        YueHaibing <yuehaibing@...wei.com>
Subject: Re: [PATCH] ASoC: amd: AMD RV RT5682 should depends on CROS_EC

On 3/3/20 3:05 AM, Enric Balletbo i Serra wrote:
> If SND_SOC_AMD_RV_RT5682_MACH=y, below kconfig and build errors can be seen:
> 
>  WARNING: unmet direct dependencies detected for SND_SOC_CROS_EC_CODEC
>  WARNING: unmet direct dependencies detected for I2C_CROS_EC_TUNNEL
> 
>  ld: drivers/i2c/busses/i2c-cros-ec-tunnel.o: in function `ec_i2c_xfer':
>  i2c-cros-ec-tunnel.c:(.text+0x2fc): undefined reference to `cros_ec_cmd_xfer_status'
>  ld: sound/soc/codecs/cros_ec_codec.o: in function `wov_host_event':
>  cros_ec_codec.c:(.text+0x4fb): undefined reference to `cros_ec_get_host_event'
>  ld: sound/soc/codecs/cros_ec_codec.o: in function `send_ec_host_command':
>  cros_ec_codec.c:(.text+0x831): undefined reference to `cros_ec_cmd_xfer_status'
> 
> This is because it will select SND_SOC_CROS_EC_CODEC and I2c_CROS_EC_TUNNEL but
> both depends on CROS_EC.
> 
> Fixes: 6b8e4e7db3cd ("ASoC: amd: Add machine driver for Raven based platform")
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>

Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

Thanks.

> ---
> 
>  sound/soc/amd/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
> index b29ef1373946..bce4cee5cb54 100644
> --- a/sound/soc/amd/Kconfig
> +++ b/sound/soc/amd/Kconfig
> @@ -33,6 +33,6 @@ config SND_SOC_AMD_RV_RT5682_MACH
>  	select SND_SOC_MAX98357A
>  	select SND_SOC_CROS_EC_CODEC
>  	select I2C_CROS_EC_TUNNEL
> -	depends on SND_SOC_AMD_ACP3x && I2C
> +	depends on SND_SOC_AMD_ACP3x && I2C && CROS_EC
>  	help
>  	 This option enables machine driver for RT5682 and MAX9835.
> 


-- 
~Randy