linux-kernel - [PATCH 5.4 079/152] drm/amdgpu: Drop DRIVER_USE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue,  3 Mar 2020 18:42:57 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     linux-kernel@...r.kernel.org
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        stable@...r.kernel.org, Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        Hawking Zhang <Hawking.Zhang@....com>,
        Xiaojie Yuan <xiaojie.yuan@....com>,
        Evan Quan <evan.quan@....com>,
        "Tianci.Yin" <tianci.yin@....com>,
        Marek Olšák <marek.olsak@....com>,
        Hans de Goede <hdegoede@...hat.com>,
        Emil Velikov <emil.velikov@...labora.com>,
        Daniel Vetter <daniel.vetter@...el.com>
Subject: [PATCH 5.4 079/152] drm/amdgpu: Drop DRIVER_USE_AGP

From: Daniel Vetter <daniel.vetter@...ll.ch>

commit 8a3bddf67ce88b96531fb22c5a75d7f4dc41d155 upstream.

This doesn't do anything except auto-init drm_agp support when you
call drm_get_pci_dev(). Which amdgpu stopped doing with

commit b58c11314a1706bf094c489ef5cb28f76478c704
Author: Alex Deucher <alexander.deucher@....com>
Date:   Fri Jun 2 17:16:31 2017 -0400

    drm/amdgpu: drop deprecated drm_get_pci_dev and drm_put_dev

No idea whether this was intentional or accidental breakage, but I
guess anyone who manages to boot a this modern gpu behind an agp
bridge deserves a price. A price I never expect anyone to ever collect
:-)

Cc: Alex Deucher <alexander.deucher@....com>
Cc: "Christian König" <christian.koenig@....com>
Cc: Hawking Zhang <Hawking.Zhang@....com>
Cc: Xiaojie Yuan <xiaojie.yuan@....com>
Cc: Evan Quan <evan.quan@....com>
Cc: "Tianci.Yin" <tianci.yin@....com>
Cc: "Marek Olšák" <marek.olsak@....com>
Cc: Hans de Goede <hdegoede@...hat.com>
Reviewed-by: Emil Velikov <emil.velikov@...labora.com>
Reviewed-by: Alex Deucher <alexander.deucher@....com>
Signed-off-by: Daniel Vetter <daniel.vetter@...el.com>
Signed-off-by: Alex Deucher <alexander.deucher@....com>
Cc: stable@...r.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -1421,7 +1421,7 @@ amdgpu_get_crtc_scanout_position(struct
 
 static struct drm_driver kms_driver = {
 	.driver_features =
-	    DRIVER_USE_AGP | DRIVER_ATOMIC |
+	    DRIVER_ATOMIC |
 	    DRIVER_GEM |
 	    DRIVER_RENDER | DRIVER_MODESET | DRIVER_SYNCOBJ,
 	.load = amdgpu_driver_load_kms,