linux-kernel - Re: [PATCHv3 2/2] serial/sysrq: Add MAGIC_SYSRQ_SERIAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 3 Mar 2020 18:06:53 +0000
From:   Dmitry Safonov <dima@...sta.com>
To:     kbuild test robot <lkp@...el.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv3 2/2] serial/sysrq: Add MAGIC_SYSRQ_SERIAL_SEQUENCE



On 3/3/20 4:31 AM, kbuild test robot wrote:
> Hi Dmitry,
[..]

> New smatch warnings:
> drivers/tty/serial/serial_core.c:3123 uart_try_toggle_sysrq() warn: unsigned '++port->sysrq_seq' is never less than zero.

False-positive as just a few lines above:
:        if (ARRAY_SIZE(sysrq_toggle_seq) <= 1)
:			return false;

I hope it's fine just to ignore this rather than complicate anyhow code
to suppress the warning.

Thanks,
          Dmitry