linux-kernel - Re: [PATCH v2] perf bench: Share 'start', 'end', 'runtime' global vars

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 3 Mar 2020 16:19:37 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>,
        Davidlohr Bueso <dave@...olabs.net>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] perf bench: Share 'start', 'end', 'runtime' global
 vars

Em Tue, Mar 03, 2020 at 07:28:52PM +0100, Thomas Gleixner escreveu:
> Arnaldo Carvalho de Melo <arnaldo.melo@...il.com> writes:
> >> > Don't we have header files for that?
> >  
> >> Sure, that was the laziest/quickest way to "fix" that, the other was to
> >> stick a 'static' in front of it.
> >  
> >> I'll go see if pushing them to a header file will not clash with other
> >> stuff.
> >
> > Better now? Had to prefix those, not to clash with local variables when
> > adding it to bench/bench.h.
> 
> Yes.
> 
> > Looking at the patch more can be done to share those benchmark
> > arguments, but this is the second minimal patch to get tools/perf to
> > build with the latest gcc (the one in Fedora rawhide and some other
> > distros).
> 
> Right, but yes there is definitely quite some overlap there.
> 
> Acked-by: Thomas Gleixner <tglx@...utronix.de>

Thanks, adding it to the cset,

- Arnaldo