linux-kernel - [PATCH] x86/syscalls: deasmlinkage syscall table definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 3 Mar 2020 23:36:42 +0300
From:   Alexey Dobriyan <adobriyan@...il.com>
To:     tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, hpa@...or.com,
        luto@...nel.org
Cc:     linux-kernel@...r.kernel.org, x86@...nel.org
Subject: [PATCH] x86/syscalls: deasmlinkage syscall table definition

I think that "sys_call_ptr_t" type being function pointer to asmlinkage
function is enough, array itself doesn't need to be asmlinkage.

It is not referenced by assembly code anymore anyway.

Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>
---

 arch/x86/entry/syscall_64.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/arch/x86/entry/syscall_64.c
+++ b/arch/x86/entry/syscall_64.c
@@ -24,7 +24,7 @@ SYSCALL_DEFINE0(ni_syscall)
 #define __SYSCALL_64(nr, sym, qual) [nr] = sym,
 #define __SYSCALL_X32(nr, sym, qual)
 
-asmlinkage const sys_call_ptr_t sys_call_table[__NR_syscall_max+1] = {
+const sys_call_ptr_t sys_call_table[__NR_syscall_max + 1] = {
 	/*
 	 * Smells like a compiler bug -- it doesn't work
 	 * when the & below is removed.
@@ -41,7 +41,7 @@ asmlinkage const sys_call_ptr_t sys_call_table[__NR_syscall_max+1] = {
 #define __SYSCALL_64(nr, sym, qual)
 #define __SYSCALL_X32(nr, sym, qual) [nr] = sym,
 
-asmlinkage const sys_call_ptr_t x32_sys_call_table[__NR_syscall_x32_max+1] = {
+const sys_call_ptr_t x32_sys_call_table[__NR_syscall_x32_max + 1] = {
 	/*
 	 * Smells like a compiler bug -- it doesn't work
 	 * when the & below is removed.