[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200303205303.GA10772@avx2>
Date: Tue, 3 Mar 2020 23:53:03 +0300
From: Alexey Dobriyan <adobriyan@...il.com>
To: Matthew Wilcox <willy@...radead.org>
Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] proc: Use ppos instead of m->version
On Tue, Mar 03, 2020 at 12:29:23PM -0800, Matthew Wilcox wrote:
> On Tue, Mar 03, 2020 at 10:55:29PM +0300, Alexey Dobriyan wrote:
> > On Sat, Feb 29, 2020 at 08:59:08AM -0800, Matthew Wilcox wrote:
> > > -static void *m_next(struct seq_file *m, void *v, loff_t *pos)
> > > +static void *m_next(struct seq_file *m, void *v, loff_t *ppos)
> >
> > This looks like hungarian notation.
>
> It's the standard naming convention used throughout the VFS. loff_t is
> pos, loff_t * is ppos.
>
> $ git grep 'loff_t \*' fs/*.c |wc
> 77 556 5233
> $ git grep 'loff_t \*ppos' fs/*.c |wc
> 43 309 2974
> $ git grep 'loff_t \*pos' fs/*.c |wc
> 22 168 1524
Yes, people copy-pasted terrible thing for years!
Oh well, whatever...
Powered by blists - more mailing lists