linux-kernel - RE: [PATCH v3 8/9] arm64: dts: ls1028a: add "fsl,vf610-edma" compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 3 Mar 2020 22:43:16 +0000
From:   Leo Li <leoyang.li@....com>
To:     Michael Walle <michael@...le.cc>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Shawn Guo <shawnguo@...nel.org>, Jiri Slaby <jslaby@...e.com>,
        Peng Fan <peng.fan@....com>,
        Vabhav Sharma <vabhav.sharma@....com>,
        Yuan Yao <yao.yuan@....com>
Subject: RE: [PATCH v3 8/9] arm64: dts: ls1028a: add "fsl,vf610-edma"
 compatible



> -----Original Message-----
> From: Michael Walle <michael@...le.cc>
> Sent: Tuesday, March 3, 2020 11:43 AM
> To: linux-serial@...r.kernel.org; devicetree@...r.kernel.org; linux-
> kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>; Rob Herring
> <robh+dt@...nel.org>; Mark Rutland <mark.rutland@....com>; Shawn
> Guo <shawnguo@...nel.org>; Leo Li <leoyang.li@....com>; Jiri Slaby
> <jslaby@...e.com>; Peng Fan <peng.fan@....com>; Vabhav Sharma
> <vabhav.sharma@....com>; Yuan Yao <yao.yuan@....com>; Michael Walle
> <michael@...le.cc>
> Subject: [PATCH v3 8/9] arm64: dts: ls1028a: add "fsl,vf610-edma" compatible
> 
> The bootloader does the IOMMU fixup and dynamically adds the "iommus"
> property to devices according to its compatible string. In case of the eDMA
> controller this property is missing. Add it. After that the IOMMU will work
> with the eDMA core.

It probably makes sense to have the fsl,vf610-edma as a secondary compatible.  But I think it probably need an update to the binding document too(especially the compatible is required to function).  Also looks like the recent update for the binding has a typo for " fsl,fsl,ls1028a-edma", can you also fix that all together?

> 
> Signed-off-by: Michael Walle <michael@...le.cc>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 0bf375ec959b..0843cfbe7ae1 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -335,7 +335,7 @@
> 
>  		edma0: dma-controller@...0000 {
>  			#dma-cells = <2>;
> -			compatible = "fsl,ls1028a-edma";
> +			compatible = "fsl,ls1028a-edma", "fsl,vf610-edma";
>  			reg = <0x0 0x22c0000 0x0 0x10000>,
>  			      <0x0 0x22d0000 0x0 0x10000>,
>  			      <0x0 0x22e0000 0x0 0x10000>;
> --
> 2.20.1