linux-kernel - Re: [PATCH net 4/4] dpaa_eth: FMan erratum A050385 workaround

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 03 Mar 2020 15:54:26 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     madalin.bucur@....nxp.com
Cc:     netdev@...r.kernel.org, robh+dt@...nel.org, mark.rutland@....com,
        shawnguo@...nel.org, leoyang.li@....com,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        madalin.bucur@....com
Subject: Re: [PATCH net 4/4] dpaa_eth: FMan erratum A050385 workaround

From: Madalin Bucur <madalin.bucur@....nxp.com>
Date: Tue,  3 Mar 2020 17:55:39 +0200

> +#define DPAA_FD_DATA_ALIGNMENT  ((fman_has_errata_a050385()) ? \

You don't need parenthesis around that fman_has_errata_a050385() call.

> +#define dpaa_bp_size(raw_size) ((SKB_WITH_OVERHEAD(raw_size)) & \

Similar again for SKB_WITH_OVERHEAD()

Also, how often does this errata code trigger on effected platforms and
what is the performance degradation from that?  I don't see this analysis
performed anywhere.