linux-kernel - Re: [PATCH] pinctrl: sprd: Fix the kconfig warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 2 Mar 2020 20:45:35 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Baolin Wang <baolin.wang7@...il.com>, linus.walleij@...aro.org
Cc:     orsonzhai@...il.com, zhang.lyra@...il.com,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: sprd: Fix the kconfig warning

On 3/2/20 7:32 PM, Baolin Wang wrote:
> On X86 plaform, if the CONFIG_OF is not selected, and set the
> CONFIG_SPRD_SC9860 as 'm', that will cause below waring:
> 
> WARNING: unmet direct dependencies detected for PINCTRL_SPRD
>   Depends on [n]: PINCTRL [=y] && OF [=n] && (ARCH_SPRD || COMPILE_TEST [=y])
>   Selected by [m]:
>   - PINCTRL_SPRD_SC9860 [=m] && PINCTRL [=y]
> 
> Thus move the configuration dependency under CONFIG_PINCTRL_SPRD_SC9860
> to fix the warning.
> 
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Signed-off-by: Baolin Wang <baolin.wang7@...il.com>

Works for me.  Thanks.

Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested


> ---
>  drivers/pinctrl/sprd/Kconfig | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pinctrl/sprd/Kconfig b/drivers/pinctrl/sprd/Kconfig
> index c9e7f0b..eef35d0 100644
> --- a/drivers/pinctrl/sprd/Kconfig
> +++ b/drivers/pinctrl/sprd/Kconfig
> @@ -4,9 +4,7 @@
>  #
>  
>  config PINCTRL_SPRD
> -	tristate "Spreadtrum pinctrl driver"
> -	depends on OF
> -	depends on ARCH_SPRD || COMPILE_TEST
> +	tristate
>  	select PINMUX
>  	select PINCONF
>  	select GENERIC_PINCONF
> @@ -16,6 +14,8 @@ config PINCTRL_SPRD
>  
>  config PINCTRL_SPRD_SC9860
>  	tristate "Spreadtrum SC9860 pinctrl driver"
> +	depends on OF
> +	depends on ARCH_SPRD || COMPILE_TEST
>  	select PINCTRL_SPRD
>  	help
>  	  Say Y here to enable Spreadtrum SC9860 pinctrl driver
> 


-- 
~Randy