linux-kernel - Re: [PATCH] input: keyboard: applespi: Use new structure for SPI transfer delays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 2 Mar 2020 22:03:51 -0800
From:   "Life is hard, and then you die" <ronald@...ovation.ch>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Sergiu Cuciurean <sergiu.cuciurean@...log.com>,
        linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
        dmitry.torokhov@...il.com, nikolas@....org,
        gregkh@...uxfoundation.org, maowenan@...wei.com
Subject: Re: [PATCH] input: keyboard: applespi: Use new structure for SPI
 transfer delays


On Mon, Mar 02, 2020 at 01:09:32PM +0200, Andy Shevchenko wrote:
> On Fri, Feb 28, 2020 at 07:26:16PM -0800, Life is hard, and then you die wrote:
> > On Thu, Feb 27, 2020 at 02:45:34PM +0200, Sergiu Cuciurean wrote:
> 
> ...
> 
> > > -	wr_t->delay_usecs = SPI_RW_CHG_DELAY_US;
> > > +	wr_t->delay.value = SPI_RW_CHG_DELAY_US;
> > > +	wr_t->delay.unit = SPI_DELAY_UNIT_USECS;
> > 
> > Looks good to me and tested to confirm things still work.
> 
> Ronald, we have the established tags for such, like Tested-by:, Reviewed-by:.

Apologies, that was sloppy of me. So:

Tested-by: Ronald Tschalär <ronald@...ovation.ch>
Reviewed-by: Ronald Tschalär <ronald@...ovation.ch>


  Cheers,

  Ronald