linux-kernel - Re: [PATCH] platform: chrome: cros_ec_spi: Use new structure for SPI transfer delays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 3 Mar 2020 11:01:26 +0100
From:   Enric Balletbo i Serra <enric.balletbo@...labora.com>
To:     Sergiu Cuciurean <sergiu.cuciurean@...log.com>,
        linux-kernel@...r.kernel.org, groeck@...omium.org,
        bleung@...omium.org
Subject: Re: [PATCH] platform: chrome: cros_ec_spi: Use new structure for SPI
 transfer delays

Hi Sergiu

On 27/2/20 15:09, Sergiu Cuciurean wrote:
> In a recent change to the SPI subsystem [1], a new `delay` struct was added
> to replace the `delay_usecs`. This change replaces the current
> `delay_usecs` with `delay` for this driver.
> 
> The `spi_transfer_delay_exec()` function [in the SPI framework] makes sure
> that both `delay_usecs` & `delay` are used (in this order to preserve
> backwards compatibility).
> 
> [1] commit bebcfd272df6 ("spi: introduce `delay` field for
> `spi_transfer` + spi_transfer_delay_exec()")
> 
> Signed-off-by: Sergiu Cuciurean <sergiu.cuciurean@...log.com>
> ---

Applied for 5.7

>  drivers/platform/chrome/cros_ec_spi.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/chrome/cros_ec_spi.c b/drivers/platform/chrome/cros_ec_spi.c
> index 46786d2d679a..665ab154bb4f 100644
> --- a/drivers/platform/chrome/cros_ec_spi.c
> +++ b/drivers/platform/chrome/cros_ec_spi.c
> @@ -127,7 +127,8 @@ static int terminate_request(struct cros_ec_device *ec_dev)
>  	 */
>  	spi_message_init(&msg);
>  	memset(&trans, 0, sizeof(trans));
> -	trans.delay_usecs = ec_spi->end_of_msg_delay;
> +	trans.delay.value = ec_spi->end_of_msg_delay;
> +	trans.delay.unit = SPI_DELAY_UNIT_NSECS;
>  	spi_message_add_tail(&trans, &msg);
>  
>  	ret = spi_sync_locked(ec_spi->spi, &msg);
> @@ -416,7 +417,8 @@ static int do_cros_ec_pkt_xfer_spi(struct cros_ec_device *ec_dev,
>  	spi_message_init(&msg);
>  	if (ec_spi->start_of_msg_delay) {
>  		memset(&trans_delay, 0, sizeof(trans_delay));
> -		trans_delay.delay_usecs = ec_spi->start_of_msg_delay;
> +		trans_delay.delay.value = ec_spi->start_of_msg_delay;
> +		trans_delay.delay.unit = SPI_DELAY_UNIT_USECS;
>  		spi_message_add_tail(&trans_delay, &msg);
>  	}
>  
>