lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 3 Mar 2020 10:08:45 +0000 From: Valentin Schneider <valentin.schneider@....com> To: Mel Gorman <mgorman@...hsingularity.net>, Ingo Molnar <mingo@...nel.org> Cc: Peter Zijlstra <peterz@...radead.org>, Vincent Guittot <vincent.guittot@...aro.org>, Juri Lelli <juri.lelli@...hat.com>, Dietmar Eggemann <dietmar.eggemann@....com>, Steven Rostedt <rostedt@...dmis.org>, Ben Segall <bsegall@...gle.com>, Phil Auld <pauld@...hat.com>, Hillf Danton <hdanton@...a.com>, LKML <linux-kernel@...r.kernel.org>, Lukasz Luba <lukasz.luba@....com> Subject: Re: [PATCH] sched/fair: Fix kernel build warning in test_idle_cores() for !SMT NUMA On 2/27/20 2:02 PM, Mel Gorman wrote: > Building against tip/sched/core as of as ff7db0bf24db ("sched/numa: Prefer > using an idle CPU as a migration target instead of comparing tasks") with > the arm64 defconfig (which doesn't have CONFIG_SCHED_SMT set) leads to: > > kernel/sched/fair.c:1525:20: warning: âtest_idle_coresâ declared âstaticâ but never defined [-Wunused-function] ^ ^ ^ ^ For some reason the quotes got turned into â in your edit. Doesn't really matter TBH. > static inline bool test_idle_cores(int cpu, bool def); > ^~~~~~~~~~~~~~~ > > Rather than define it in its own CONFIG_SCHED_SMT #define island, bunch it > up with test_idle_cores(). > > Fixes: ff7db0bf24db ("sched/numa: Prefer using an idle CPU as a migration target instead of comparing tasks") > [mgorman@...hsingularity.net: Edit changelog, minor style change] > Signed-off-by: Valentin Schneider <valentin.schneider@....com> > Signed-off-by: Mel Gorman <mgorman@...hsingularity.net> Could we get this in tip (and hopefully -next will follow shortly)? We're at like the third duplicate fix on the list already.
Powered by blists - more mailing lists