linux-kernel - Re: [PATCH 1/3] sched/fair: Fix statistics for find_idlest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200303114444.GM3818@techsingularity.net>
Date:   Tue, 3 Mar 2020 11:44:44 +0000
From:   Mel Gorman <mgorman@...hsingularity.net>
To:     Vincent Guittot <vincent.guittot@...aro.org>
Cc:     Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Juri Lelli <juri.lelli@...hat.com>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ben Segall <bsegall@...gle.com>,
        Valentin Schneider <valentin.schneider@....com>,
        Lukasz Luba <lukasz.luba@....com>,
        Phil Auld <pauld@...hat.com>, Hillf Danton <hdanton@...a.com>,
        Anshuman Khandual <anshuman.khandual@....com>,
        Naresh Kamboju <naresh.kamboju@...aro.org>,
        Paul McKenney <paulmck@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] sched/fair: Fix statistics for find_idlest_group()

On Tue, Mar 03, 2020 at 12:14:07PM +0100, Vincent Guittot wrote:
> Hi Mel,
> 
> On Tue, 3 Mar 2020 at 12:03, Mel Gorman <mgorman@...hsingularity.net> wrote:
> >
> > From: Vincent Guittot <vincent.guittot@...aro.org>
> >
> > From: Vincent Guittot <vincent.guittot@...aro.org>
> >
> > sgs->group_weight is not set while gathering statistics in
> > update_sg_wakeup_stats(). This means that a group can be classified as
> > fully busy with 0 running tasks if utilization is high enough.
> >
> > This path is mainly used for fork and exec.
> >
> > Fixes: 57abff067a08 ("sched/fair: Rework find_idlest_group()")
> > Signed-off-by: Vincent Guittot <vincent.guittot@...aro.org>
> > Signed-off-by: Ingo Molnar <mingo@...nel.org>
> > Acked-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> > Acked-by: Mel Gorman <mgorman@...hsingularity.net>
> > Signed-off-by: Mel Gorman <mgorman@...hsingularity.net>
> > Link: https://lore.kernel.org/r/20200218144534.4564-1-vincent.guittot@linaro.org
> 
> This one has been merged in tip/sched/urgent
> 

I know and it appears in next but not in mainline yet. As tip/sched/core
is the development baseline for scheduler patches, it should have the
patch -- most likely via mainline to preserve git history. By including
it here, I wanted to highlight that anyone working on tip/sched/core at
the moment should include the patch if they want to avoid invalidating
any test results.

-- 
Mel Gorman
SUSE Labs