linux-kernel - Re: [PATCH v5 2/5] MIPS: DTS: CI20: fix PMU definitions for ACT8600

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 3 Mar 2020 13:10:22 +0100
From:   "H. Nikolaus Schaller" <hns@...delico.com>
To:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc:     Paul Boddie <paul@...die.org.uk>,
        Paul Cercueil <paul@...pouillou.net>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Paul Burton <paulburton@...nel.org>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Kees Cook <keescook@...omium.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, linux-mips@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Discussions about the Letux Kernel 
        <letux-kernel@...nphoenux.org>, stable <stable@...r.kernel.org>
Subject: Re: [PATCH v5 2/5] MIPS: DTS: CI20: fix PMU definitions for ACT8600

Hi Thomas,

> Am 03.03.2020 um 11:18 schrieb Thomas Bogendoerfer <tsbogend@...ha.franken.de>:
> 
> On Sat, Feb 29, 2020 at 08:45:45PM +0100, H. Nikolaus Schaller wrote:
>> There is a ACT8600 on the CI20 board and the bindings of the
>> ACT8865 driver have changed without updating the CI20 device
>> tree. Therefore the PMU can not be probed successfully and
>> is running in power-on reset state.
>> 
>> Fix DT to match the latest act8865-regulator bindings.
>> 
>> Fixes: 73f2b940474d ("MIPS: CI20: DTS: Add I2C nodes")
> 
> I see checkpatch warnings in this patch, could please fix them ?

Ah, ok. The comment. Well, on a 5k screen this 80 character limit
is really outdated. But checkpatch is the king :)

Noted for v6.

> And please seperate fixes from improvments, thank you.

What do you mean by "separate"? Two separate patches?
This patch only contains fixes (which I would consider
all of them to be improvements).

> 
> Thomas.

BR and thanks,
Nikolaus