linux-kernel - Re: [PATCH] regulator: anatop: Drop error message for -EPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 3 Mar 2020 12:30:10 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Anson Huang <Anson.Huang@....com>
Cc:     lgirdwood@...il.com, linux-kernel@...r.kernel.org,
        Linux-imx@....com
Subject: Re: [PATCH] regulator: anatop: Drop error message for -EPROBE_DEFER

On Tue, Mar 03, 2020 at 11:14:21AM +0800, Anson Huang wrote:
> devm_regulator_register() could return -EPROBE_DEFER when trying to
> get init data and NOT all resources are available at that time, for
> this case, error message should NOT be present, the driver will call
> probe again later, so drop error message for -EPROBE_DEFER.

No, this is not good - it means that if there is some problem the user
will not get any information about why the driver is not instantiating
and how to fix it.  At most lower the message to dev_dbg().

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)