linux-kernel - Re: linux-next: Tree for Mar 2 (pinctrl/sprd/pinctrl-sprd.c)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 3 Mar 2020 13:44:47 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Randy Dunlap <rdunlap@...radead.org>,
        Baolin Wang <baolin.wang@...eadtrum.com>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        Baolin Wang <baolin.wang7@...il.com>
Subject: Re: linux-next: Tree for Mar 2 (pinctrl/sprd/pinctrl-sprd.c)

On Mon, Mar 2, 2020 at 5:36 PM Randy Dunlap <rdunlap@...radead.org> wrote:
> On 3/1/20 11:25 PM, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20200228:
> >
>
> on i386 or x86_64:
>
> kconfig warnings and build error:
>
> WARNING: unmet direct dependencies detected for PINCTRL_SPRD
>   Depends on [n]: PINCTRL [=y] && OF [=n] && (ARCH_SPRD || COMPILE_TEST [=y])
>   Selected by [m]:
>   - PINCTRL_SPRD_SC9860 [=m] && PINCTRL [=y]
>
> ../drivers/pinctrl/sprd/pinctrl-sprd.c: In function 'sprd_dt_node_to_map':
> ../drivers/pinctrl/sprd/pinctrl-sprd.c:282:8: error: implicit declaration of function 'pinconf_generic_parse_dt_config'; did you mean 'pinconf_generic_dump_config'? [-Werror=implicit-function-declaration]
>   ret = pinconf_generic_parse_dt_config(np, pctldev, &configs,
>         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>         pinconf_generic_dump_config

Should be fixed with

depends on OF=y

in drivers/pinctrl/sprd/Kconfig

Baolin are you onto it?

Yours,
Linus Walleij