linux-kernel - Re: [PATCH v3 2/2] arm64: dts: rockchip: Add initial support for Pinebook Pro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46a66389-c709-2c16-dd9a-f7fd6371a768@manjaro.org>
Date:   Wed, 4 Mar 2020 19:24:41 +0100
From:   Tobias Schramm <t.schramm@...jaro.org>
To:     Johan Jonker <jbx6244@...il.com>,
        Tobias Schramm <t.schramm@...jaro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Heiko Stuebner <heiko@...ech.de>,
        Andy Yan <andy.yan@...k-chips.com>
Cc:     Douglas Anderson <dianders@...omium.org>,
        Jagan Teki <jagan@...rulasolutions.com>,
        Markus Reichl <m.reichl@...etechno.de>,
        Alexis Ballier <aballier@...too.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        Nick Xie <nick@...das.com>,
        Kever Yang <kever.yang@...k-chips.com>,
        Vivek Unune <npcomplete13@...il.com>,
        Katsuhiro Suzuki <katsuhiro@...suster.net>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Vasily Khoruzhick <anarsoul@...il.com>
Subject: Re: [PATCH v3 2/2] arm64: dts: rockchip: Add initial support for
 Pinebook Pro

Hi Johan,

thanks for the additional feedback. I'll send a v4 with your fixes included.

>> +		partitions {
>> +			compatible = "fixed-partitions";
>> +			#address-cells = <1>;
>> +			#size-cells = <1>;
>> +
>> +			loader@...0 {
>> +				label = "loader";
>> +				reg = <0x0 0x3F8000>;
>> +			};
>> +
>> +			env@...000 {
>> +				label = "env";
>> +				reg = <0x3F8000 0x8000>;
>> +			};
>> +
>> +			vendor@...000 {
>> +				label = "vendor";
>> +				reg = <0x7C0000 0x40000>;
>> +			};
>> +		};
> 
> Partitions are normaly up to the user and should not be included to dts
> files,
> else could you explain why we need this exception?
> 
Right. I don't see any reason why we would need to keep it either. I'll
remove it.

Tobias