linux-kernel - Re: [Patch for-rc v2] RDMA/siw: Fix failure handling during device creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200304182755.GA7428@ziepe.ca>
Date:   Wed, 4 Mar 2020 14:27:55 -0400
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     Bernard Metzler <bmt@...ich.ibm.com>
Cc:     dledford@...hat.com, linux-kernel@...r.kernel.org,
        linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
        syzkaller-bugs@...glegroups.com
Subject: Re: [Patch for-rc v2] RDMA/siw: Fix failure handling during device
 creation

On Mon, Mar 02, 2020 at 04:58:14PM +0100, Bernard Metzler wrote:
> A failing call to ib_device_set_netdev() during device creation
> caused system crash due to xa_destroy of uninitialized xarray
> hit by device deallocation. Fixed by moving xarray initialization
> before potential device deallocation.
> 
> Fixes: bdcf26bf9b3a (rdma/siw: network and RDMA core interface)
> Reported-by: syzbot+2e80962bedd9559fe0b3@...kaller.appspotmail.com
> Signed-off-by: Bernard Metzler <bmt@...ich.ibm.com>
> ---
> v1 -> v2:
> - Fix here only potential system crash during failing device
>   creation, but not missing correct error propagation.
> 
>  drivers/infiniband/sw/siw/siw_main.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Applied to for-rc

Thanks,
Jason