linux-kernel - Re: [PATCH] KVM: fix Kconfig menu text for -Werror

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200304190750.GF21662@linux.intel.com>
Date:   Wed, 4 Mar 2020 11:07:50 -0800
From:   Sean Christopherson <sean.j.christopherson@...el.com>
To:     "Jason A. Donenfeld" <Jason@...c4.com>
Cc:     pbonzini@...hat.com, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: fix Kconfig menu text for -Werror

On Wed, Mar 04, 2020 at 06:42:21PM +0800, Jason A. Donenfeld wrote:
> This was evidently copy and pasted from the i915 driver, but the text
> wasn't updated.
> 
> Fixes: 4f337faf1c55 ("KVM: allow disabling -Werror")
> Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>
> ---
>  arch/x86/kvm/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
> index 1bb4927030af..29bd4dc3363e 100644
> --- a/arch/x86/kvm/Kconfig
> +++ b/arch/x86/kvm/Kconfig
> @@ -68,7 +68,7 @@ config KVM_WERROR
>  	depends on (X86_64 && !KASAN) || !COMPILE_TEST
>  	depends on EXPERT
>  	help
> -	  Add -Werror to the build flags for (and only for) i915.ko.
> +	  Add -Werror to the build flags for kvm.ko.

The -Werror flag also gets used when compiling kvm-intel.ko and kvm-amd.ko
as separate modules, as well as when KVM is built into the kernel and there
is no kvm.ko.  Probably easiest to simply say "for KVM".

>  
>  	  If in doubt, say "N".
>  
> -- 
> 2.25.1
>