linux-kernel - Re: [PATCH] btrfs: implement migratepage callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200304201959.GA800002@carbon.DHCP.thefacebook.com>
Date:   Wed, 4 Mar 2020 12:19:59 -0800
From:   Roman Gushchin <guro@...com>
To:     Chris Mason <clm@...com>
CC:     Josef Bacik <josef@...icpanda.com>,
        David Sterba <dsterba@...e.com>, <linux-btrfs@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <kernel-team@...com>,
        Rik van Riel <riel@...riel.com>
Subject: Re: [PATCH] btrfs: implement migratepage callback

On Wed, Mar 04, 2020 at 02:53:21PM -0500, Chris Mason wrote:
> 
> 
> On 4 Mar 2020, at 14:50, Roman Gushchin wrote:
> 
> > Currently btrfs doesn't provide a migratepage callback. It means that
> > fallback_migrate_page()	is used to migrate btrfs pages.
> > 
> > fallback_migrate_page() cannot move dirty pages, instead it tries to
> > flush them (in sync mode) or just fails (in async mode).
> > 
> > In the sync mode pages which are scheduled to be processed by
> > btrfs_writepage_fixup_worker() can't be effectively flushed by the
> > migration code, because there is no established way to wait for the
> > completion of the delayed work.
> > 
> > It all leads to page migration failures.
> > 
> > To fix it the patch implements a btrs-specific migratepage callback,
> > which is similar to iomap_migrate_page() used by some other fs, except
> > it does take care of the PagePrivate2 flag which is used for data
> > ordering purposes.
> 
> Since the default migratepage didn’t copy PagePrivate2, didn’t you find it
> was also causing pages to get funneled into the fixup worker flow?

A good question.

I've definitely seen a lot of fixup worker activity.

On the other hand the default (fallback) migration path is flushing
the page first (if dirty), so it should not move dirty pages.
If PagePrivate2 can outlive PageDirty, then the answer is yes.

Thanks!