lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 4 Mar 2020 12:45:27 -0800 (PST)
From:   David Rientjes <>
To:     David Hildenbrand <>
cc:     "Huang, Ying" <>,
        Andrew Morton <>,,,
        Dave Hansen <>,
        Mel Gorman <>, Vlastimil Babka <>,
        Zi Yan <>, Michal Hocko <>,
        Peter Zijlstra <>,
        Minchan Kim <>,
        Johannes Weiner <>,
        Hugh Dickins <>
Subject: Re: [PATCH -V2] mm: Add PageLayzyFree() helper functions for

On Wed, 4 Mar 2020, David Hildenbrand wrote:

> In general, I don't think this patch really improves the situation ...
> it's only a handful of places where this change slightly makes the code
> easier to understand. And there, only slightly ... I'd prefer better
> comments instead (e.g., in PageAnon()), documenting what it means for a
> anon page to either have PageSwapBacked() set or not.

Agreed, I think any changes to clarify what PageSwapBacked means when it's 
set and when it's clear for PageAnon should be in the form of a comment, 
likely in page-flags.h.  That's currently lacking for lazy free pages.

Powered by blists - more mailing lists