linux-kernel - AW: [PATCH 5.5 110/176] MIPS: VPE: Fix a double free and a memory leak in release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adf1859b4dcc497285ebbda017ece22d@bfs.de>
Date:   Wed, 4 Mar 2020 21:28:31 +0000
From:   Walter Harms <wharms@....de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Paul Burton <paulburton@...nel.org>,
        "ralf@...ux-mips.org" <ralf@...ux-mips.org>,
        "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: AW: [PATCH 5.5 110/176] MIPS: VPE: Fix a double free and a memory
 leak in release_vpe()

________________________________________
Von: kernel-janitors-owner@...r.kernel.org <kernel-janitors-owner@...r.kernel.org> im Auftrag von Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Gesendet: Dienstag, 3. März 2020 18:42
An: linux-kernel@...r.kernel.org
Cc: Greg Kroah-Hartman; stable@...r.kernel.org; Christophe JAILLET; Paul Burton; ralf@...ux-mips.org; linux-mips@...r.kernel.org; kernel-janitors@...r.kernel.org
Betreff: [PATCH 5.5 110/176] MIPS: VPE: Fix a double free and a memory leak in release_vpe()

From: Christophe JAILLET <christophe.jaillet@...adoo.fr>

commit bef8e2dfceed6daeb6ca3e8d33f9c9d43b926580 upstream.

Pointer on the memory allocated by 'alloc_progmem()' is stored in
'v->load_addr'. So this is this memory that should be freed by
'release_progmem()'.

'release_progmem()' is only a call to 'kfree()'.

With the current code, there is both a double free and a memory leak.
Fix it by passing the correct pointer to 'release_progmem()'.

Fixes: e01402b115ccc ("More AP / SP bits for the 34K, the Malta bits and things. Still wants")
Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Signed-off-by: Paul Burton <paulburton@...nel.org>
Cc: ralf@...ux-mips.org
Cc: linux-mips@...r.kernel.org
Cc: linux-kernel@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

---
 arch/mips/kernel/vpe.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/arch/mips/kernel/vpe.c
+++ b/arch/mips/kernel/vpe.c
@@ -134,7 +134,7 @@ void release_vpe(struct vpe *v)
 {
        list_del(&v->list);
        if (v->load_addr)
-               release_progmem(v);
+               release_progmem(v->load_addr);
        kfree(v);
 }

since release_progmem() is kfree() it is also possible to drop "if (v->load_addr)"

jm2c

re,
 wh