linux-kernel - Re: [PATCH v3] intel_idle: Add Comet Lake support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0j+bx5fh1wv738MNoui_SaZ-c21rDnZkWOqi_GCVg5stQ@mail.gmail.com>
Date:   Wed, 4 Mar 2020 10:53:38 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Harry Pan <harry.pan@...el.com>
Cc:     LKML <linux-kernel@...r.kernel.org>, Harry Pan <gs0622@...il.com>,
        Jacob Pan <jacob.jun.pan@...ux.intel.com>,
        Len Brown <lenb@...nel.org>,
        Linux PM <linux-pm@...r.kernel.org>
Subject: Re: [PATCH v3] intel_idle: Add Comet Lake support

On Tue, Mar 3, 2020 at 10:10 AM Harry Pan <harry.pan@...el.com> wrote:
>
> Add a general C-state table in order to support Comet Lake.
>
> Signed-off-by: Harry Pan <harry.pan@...el.com>
>
> ---
>
>  drivers/idle/intel_idle.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
> index d55606608ac8..05bce595fafe 100644
> --- a/drivers/idle/intel_idle.c
> +++ b/drivers/idle/intel_idle.c
> @@ -1067,6 +1067,11 @@ static const struct idle_cpu idle_cpu_dnv = {
>         .use_acpi = true,
>  };
>
> +static const struct idle_cpu idle_cpu_cml = {
> +       .state_table = skl_cstates,
> +       .disable_promotion_to_c1e = true,

.use_acpi = true,

missing?  Otherwise you can just use idle_cpu_skl as is, can't you?

> +};
> +
>  static const struct x86_cpu_id intel_idle_ids[] __initconst = {
>         INTEL_CPU_FAM6(NEHALEM_EP,              idle_cpu_nhx),
>         INTEL_CPU_FAM6(NEHALEM,                 idle_cpu_nehalem),
> @@ -1105,6 +1110,8 @@ static const struct x86_cpu_id intel_idle_ids[] __initconst = {
>         INTEL_CPU_FAM6(ATOM_GOLDMONT_PLUS,      idle_cpu_bxt),
>         INTEL_CPU_FAM6(ATOM_GOLDMONT_D,         idle_cpu_dnv),
>         INTEL_CPU_FAM6(ATOM_TREMONT_D,          idle_cpu_dnv),
> +       INTEL_CPU_FAM6(COMETLAKE_L,             idle_cpu_cml),
> +       INTEL_CPU_FAM6(COMETLAKE,               idle_cpu_cml),
>         {}
>  };
>
> --
> 2.24.1
>