linux-kernel - Re: [PATCH 2/2] tty:serial:mvebu-uart:fix a wrong return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <c179b76e-a597-3e5f-8e79-20deb62a9423@suse.cz>
Date:   Wed, 4 Mar 2020 11:07:00 +0100
From:   Jiri Slaby <jslaby@...e.cz>
To:     唐彬 <tangbin@...s.chinamobile.com>,
        gregkh <gregkh@...uxfoundation.org>
Cc:     linux-serial <linux-serial@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] tty:serial:mvebu-uart:fix a wrong return

On 04. 03. 20, 10:37, 唐彬 wrote:
>      I'm very happy for your replay. But I don't understand, in this
> place ,it's function is to judge.You say 'the probe function is expected
> to return a negative value in case of error'？But at the top or bottom
> of the code here in mvebu_uart_probe()，there are a lot of judgments
> that return negative numbers. How do you explain that?

That's exactly the point. The function should return a negative value
and PTR_ERR already returns a negative.

That is, your patch is correct, but your commit message missed an
explanation.

thanks,
-- 
js
suse labs