linux-kernel - Re: [PATCH] vfio: platform: Switch to platform_get_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200304103950.4e98d0ff@donnerap.cambridge.arm.com>
Date:   Wed, 4 Mar 2020 10:39:50 +0000
From:   Andre Przywara <andre.przywara@....com>
To:     Eric Auger <eric.auger@...hat.com>
Cc:     eric.auger.pro@...il.com, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org, alex.williamson@...hat.com,
        stable@...r.kernel.org, cohuck@...hat.com
Subject: Re: [PATCH] vfio: platform: Switch to platform_get_irq_optional()

On Mon,  2 Mar 2020 21:37:15 +0100
Eric Auger <eric.auger@...hat.com> wrote:

> Since commit 7723f4c5ecdb ("driver core: platform: Add an error
> message to platform_get_irq*()"), platform_get_irq() calls dev_err()
> on an error. As we enumerate all interrupts until platform_get_irq()
> fails, we now systematically get a message such as:
> "vfio-platform fff51000.ethernet: IRQ index 3 not found" which is
> a false positive.
> 
> Let's use platform_get_irq_optional() instead.

Yes, that seems correct to me and avoids the false positive error message I saw before.
 
> Signed-off-by: Eric Auger <eric.auger@...hat.com>
> Cc: stable@...r.kernel.org # v5.3+

Reviewed-by: Andre Przywara <andre.przywara@....com>
Tested-by: Andre Przywara <andre.przywara@....com>

Thanks!
Andre

> ---
>  drivers/vfio/platform/vfio_platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/vfio/platform/vfio_platform.c b/drivers/vfio/platform/vfio_platform.c
> index ae1a5eb98620..1e2769010089 100644
> --- a/drivers/vfio/platform/vfio_platform.c
> +++ b/drivers/vfio/platform/vfio_platform.c
> @@ -44,7 +44,7 @@ static int get_platform_irq(struct vfio_platform_device *vdev, int i)
>  {
>  	struct platform_device *pdev = (struct platform_device *) vdev->opaque;
>  
> -	return platform_get_irq(pdev, i);
> +	return platform_get_irq_optional(pdev, i);
>  }
>  
>  static int vfio_platform_probe(struct platform_device *pdev)