linux-kernel - Re: [rcu:dev.2020.03.03b 43/45] kernel/rcu/update.c:583:2: error: implicit declaration of function 'rcu_tasks_bootup_oddness'; did you mean 'rcu_early_boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 3 Mar 2020 17:07:42 -0800
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     kbuild test robot <lkp@...el.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: Re: [rcu:dev.2020.03.03b 43/45] kernel/rcu/update.c:583:2: error:
 implicit declaration of function 'rcu_tasks_bootup_oddness'; did you mean
 'rcu_early_boot_tests'?

On Wed, Mar 04, 2020 at 07:59:13AM +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2020.03.03b
> head:   647c0bb2da5c14b25d27661fa93de7fca9042daf
> commit: d060bd985c4d160df31659a80cf5fabe1cd508b4 [43/45] rcu-tasks: Refactor RCU-tasks to allow variants to be added
> config: x86_64-defconfig (attached as .config)
> compiler: gcc-7 (Debian 7.5.0-5) 7.5.0
> reproduce:
>         git checkout d060bd985c4d160df31659a80cf5fabe1cd508b4
>         # save the attached .config to linux build tree
>         make ARCH=x86_64 
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@...el.com>
> 
> All errors (new ones prefixed by >>):
> 
>    kernel/rcu/update.c: In function 'rcupdate_announce_bootup_oddness':
> >> kernel/rcu/update.c:583:2: error: implicit declaration of function 'rcu_tasks_bootup_oddness'; did you mean 'rcu_early_boot_tests'? [-Werror=implicit-function-declaration]
>      rcu_tasks_bootup_oddness();
>      ^~~~~~~~~~~~~~~~~~~~~~~~
>      rcu_early_boot_tests
>    cc1: some warnings being treated as errors

Good catch, will fix, thank you!

							Thanx, Paul

> vim +583 kernel/rcu/update.c
> 
> 59d80fd8351b7b Paul E. McKenney 2017-04-28  567  
> 59d80fd8351b7b Paul E. McKenney 2017-04-28  568  /*
> 59d80fd8351b7b Paul E. McKenney 2017-04-28  569   * Print any significant non-default boot-time settings.
> 59d80fd8351b7b Paul E. McKenney 2017-04-28  570   */
> 59d80fd8351b7b Paul E. McKenney 2017-04-28  571  void __init rcupdate_announce_bootup_oddness(void)
> 59d80fd8351b7b Paul E. McKenney 2017-04-28  572  {
> 59d80fd8351b7b Paul E. McKenney 2017-04-28  573  	if (rcu_normal)
> 59d80fd8351b7b Paul E. McKenney 2017-04-28  574  		pr_info("\tNo expedited grace period (rcu_normal).\n");
> 59d80fd8351b7b Paul E. McKenney 2017-04-28  575  	else if (rcu_normal_after_boot)
> 59d80fd8351b7b Paul E. McKenney 2017-04-28  576  		pr_info("\tNo expedited grace period (rcu_normal_after_boot).\n");
> 59d80fd8351b7b Paul E. McKenney 2017-04-28  577  	else if (rcu_expedited)
> 59d80fd8351b7b Paul E. McKenney 2017-04-28  578  		pr_info("\tAll grace periods are expedited (rcu_expedited).\n");
> 59d80fd8351b7b Paul E. McKenney 2017-04-28  579  	if (rcu_cpu_stall_suppress)
> 59d80fd8351b7b Paul E. McKenney 2017-04-28  580  		pr_info("\tRCU CPU stall warnings suppressed (rcu_cpu_stall_suppress).\n");
> 59d80fd8351b7b Paul E. McKenney 2017-04-28  581  	if (rcu_cpu_stall_timeout != CONFIG_RCU_CPU_STALL_TIMEOUT)
> 59d80fd8351b7b Paul E. McKenney 2017-04-28  582  		pr_info("\tRCU CPU stall warnings timeout set to %d (rcu_cpu_stall_timeout).\n", rcu_cpu_stall_timeout);
> 59d80fd8351b7b Paul E. McKenney 2017-04-28 @583  	rcu_tasks_bootup_oddness();
> 59d80fd8351b7b Paul E. McKenney 2017-04-28  584  }
> 59d80fd8351b7b Paul E. McKenney 2017-04-28  585  
> 
> :::::: The code at line 583 was first introduced by commit
> :::::: 59d80fd8351b7b9a5dc7bbfa8bc4ca19f6ff3dad rcu: Print out rcupdate.c non-default boot-time settings
> 
> :::::: TO: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> :::::: CC: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org