linux-kernel - Re: [PATCH 22/30] ACPI: OSL: Add missing annotation for acpi_os_acquire

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6715482.taCdthcxpl@kreacher>
Date:   Wed, 04 Mar 2020 12:00:19 +0100
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Jules Irenge <jbi.octave@...il.com>
Cc:     boqun.feng@...il.com, linux-kernel@...r.kernel.org,
        Len Brown <lenb@...nel.org>,
        "open list:ACPI" <linux-acpi@...r.kernel.org>
Subject: Re: [PATCH 22/30] ACPI: OSL: Add missing annotation for acpi_os_acquire_lock()

On Monday, February 24, 2020 12:17:03 AM CET Jules Irenge wrote:
> Sparse reports a warning at acpi_os_acquire_lock()
> 
> warning: context imbalance in acpi_os_acquire_lock() - unexpected unlock
> 
> The root cause is the missing annotation at acpi_os_acquire_lock()
> Add the missing annotation __acquires(lockp)
> 
> Signed-off-by: Jules Irenge <jbi.octave@...il.com>
> ---
>  drivers/acpi/osl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
> index 41168c027a5a..7094abc5ffc6 100644
> --- a/drivers/acpi/osl.c
> +++ b/drivers/acpi/osl.c
> @@ -1598,6 +1598,7 @@ void acpi_os_delete_lock(acpi_spinlock handle)
>   */
>  
>  acpi_cpu_flags acpi_os_acquire_lock(acpi_spinlock lockp)
> +	__acquires(lockp)
>  {
>  	acpi_cpu_flags flags;
>  	spin_lock_irqsave(lockp, flags);
> 

Merged with the [23/30] and applied with modified subject and changelog as
5.7 material.

Thanks!