linux-kernel - Re: [PATCH] blktrace: fix dereference after null check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 04 Mar 2020 14:07:17 +0300
From:   Cengiz Can <cengiz@...nel.wtf>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Jens Axboe <axboe@...nel.dk>, Ingo Molnar <mingo@...hat.com>,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] blktrace: fix dereference after null check

On 2020-03-03 17:14, Steven Rostedt wrote:
> 
> Note, you should probably add a note in your change log that this issue 
> was
> found by Coverity. Sometimes static analyzers have a tag of some kind 
> that
> they would like patches that fix the issues they discover to be in the
> change log. This way they can track the fixes that are found by the 
> tool.
> 

I have added the Coverity issue ID and relevant notes to mark it. 
Thanks.

> 
> As I said in the other email, the above assignment still needs RCU
> annotation:
> 
> 		bt = rcu_dereference_protected(q->blk_trace,
> 				lockdep_is_held(&q->blk_trace_mutex));

I missed that. Thanks for reminding. TIL.

Please check PATCH-v2.

-- 
Cengiz Can
@cengiz_io