linux-kernel - Re: [PATCH] cgroup1: don't call release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200304165405.GI189690@mtj.thefacebook.com>
Date:   Wed, 4 Mar 2020 11:54:05 -0500
From:   Tejun Heo <tj@...nel.org>
To:     Tycho Andersen <tycho@...ho.ws>
Cc:     cgroups@...r.kernel.org, Li Zefan <lizefan@...wei.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Serge Hallyn <serge@...lyn.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cgroup1: don't call release_agent when it is ""

On Wed, Feb 19, 2020 at 12:01:29PM -0700, Tycho Andersen wrote:
> Older (and maybe current) versions of systemd set release_agent to "" when
> shutting down, but do not set notify_on_release to 0.
> 
> Since 64e90a8acb85 ("Introduce STATIC_USERMODEHELPER to mediate
> call_usermodehelper()"), we filter out such calls when the user mode helper
> path is "". However, when used in conjunction with an actual (i.e. non "")
> STATIC_USERMODEHELPER, the path is never "", so the real usermode helper
> will be called with argv[0] == "".
> 
> Let's avoid this by not invoking the release_agent when it is "".
> 
> Signed-off-by: Tycho Andersen <tycho@...ho.ws>

Applied to cgroup/for-5.6-fixes.

Thanks.

-- 
tejun